Support new curly brace syntax

[kevinschweikert]

Closes #42

This is me just jumping into the codebase but i wanted have a stab at it. Hope this helps and i'm happy to get feedback if anything needs changing!

[connorlay]

Thanks for doing this! I'll have time tomorrow to test these changes locally.

[jonatanklosko]

Partial/end expression is not allowed in {...}, it should always be a single expression. We can do this:

Suggested change

	seq(
	choice("{"),
	prec.left(
	seq(
	choice(
	$.partial_expression_value,
	$.ending_expression_value,
	$.expression_value
	),
	choice("}")
	)
	)
	)
	alias($.expression, "expression")

Aliasing as string makes the node anonymous, so it appears as directive.

[jonatanklosko]

Actually, I would consider parsing {...} as expression node, regardless if it's <div attr={...}> or <div>{...}</div>. So it would be this:

_node: ($) =>
-      choice($.doctype, $.tag, $.component, $.text, $.comment, $.directive),
+      choice($.doctype, $.tag, $.component, $.text, $.comment, $.directive, $.expression),

@connorlay wdyt?

[connorlay]

@jonatanklosko That makes sense to me!

[SteffenDE]

Is tree-sitter able to respect phx-no-curly-interpolation? It might not be worth it, but I tried to do it for vscode with Textmate Grammars but then realized they cannot support it :(

[jonatanklosko]

Is tree-sitter able to respect phx-no-curly-interpolation?

I think it may be possible, but I'm pretty sure it's not worth the complexity.

The way I would try to implement it, would be to have a separate grammar node for phx-no-curly-interpolation and two variants of tags (one with phx-no-curly-interpolation and one without). Since the tags are recursive, once a tag has phx-no-curly-interpolation we need to respect that for all children, so we would basically have to duplicate a whole chunk of the grammar.

[connorlay]

I finally got time to test this myself and it looks great! Thanks everyone!