Add syntax highlight support for <script> and <style> tags #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ((tag | ||
| (start_tag | ||
| (tag_name) @tag_name (#eq? @tag_name "script")) | ||
| (text) |
Member
There was a problem hiding this comment.
I believe you can capture the (text) node here as (text) @injection.content instead and then you can drop the #offset! property below
(and same for the style tag below)
Contributor
Author
There was a problem hiding this comment.
I tried that but it stops the capture right before the next { character inside the script tag
((tag
(start_tag
(tag_name) @tag_name (#eq? @tag_name "script"))
(text) @injection.content
(end_tag)
)
(#set! injection.language "javascript")
(#set! injection.include-children)
(#set! injection.combined)
)
and results something like this when you have several functions:
Member
There was a problem hiding this comment.
Ah yeah I see, we need to parse the entire inner contents of the tag because otherwise {/} are recognized as non-(text) nodes 👍
See: phoenixframework#37 This commit doesn't fix the grammar but add syntax highlight support for JavaScript and CSS code inside of <script> and <style> tags.
fedcho
force-pushed
the
feat/js-injections
branch
from
b9dbfbe to
1bd5ada
Compare
the-mikedavis
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add syntax highlight support for JavaScript and CSS code inside of <script> and <style> tags.
It doesn't fix the grammar.
See: #37