Change default max_frame_size#22
Open
dlindenkreuz wants to merge 1 commit intophoenixframework:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, WebSockAdapter applies a default documented limit of
:infinityon incoming WebSocket frame size. This leaves default setups unprotected against malicious oversized payloads unless they explicitly configuremax_binary_sizeon the socket transport.(More specifically, the default value is not specified and is left to the underlying web servers like Bandit)
This is inconsistent with the long polling transport for Phoenix Channels, where incoming event messages are limited to 10MB (currently hardcoded).
This PR changes the default
max_frame_sizeto 10MB to match the limit already in place for long polling. Applications that need to support larger frames can opt out by raising or removing the limit explicitly.Strictly speaking, this would be a breaking change, but then again, web socket frames >10MB are not that common. WDYT?