Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

Conversation

@joblesspoet
Copy link

@joblesspoet joblesspoet commented Oct 31, 2019

Description

In "PushInstanceIDListenerService" class Removed the deprecated FirebaseInstanceIdService class. And Implemented the FirebaseMessagingService changes.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@craigmcnamara
Copy link

craigmcnamara commented Jan 9, 2020

Thanks @joblesspoet. I was blocked by the error this pull request fixes. I made a fork, merged the patch and am running it in production now. It would be great to see this merged soon.

@joblesspoet joblesspoet requested a review from macdonst January 15, 2020 20:52
@etiennea
Copy link

This fixed my issue!

@joblesspoet
Copy link
Author

This fixed my issue!

Good to hear that....

@tbowler
Copy link

tbowler commented Feb 18, 2020

@joblesspoet
Thanks for the fix. It saved me as well.
+1 on getting this merged soon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants