Skip to content
This repository was archived by the owner on Sep 4, 2020. It is now read-only.

[DRAFT] feat: remove cordova-support-google-services dependency #2873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DRAFT] feat: remove cordova-support-google-services dependency #2873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@
"cordova-ios": ">=4.5.0",
"cordova-android": ">=7.1.0",
"cordova": ">=7.1.0"
},
"3.0.0": {
"cordova-ios": ">=4.5.0",
"cordova-android": ">=9.0.0",
"cordova": ">=9.0.0"
}
}
},
Expand Down
17 changes: 10 additions & 7 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:amazon="http://schemas.android.com/apk/lib/com.amazon.device.ads"
xmlns:rim="http://www.blackberry.com/ns/widgets"
<plugin xmlns="http://www.phonegap.com/ns/plugins/1.0"
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:amazon="http://schemas.android.com/apk/lib/com.amazon.device.ads"
xmlns:rim="http://www.blackberry.com/ns/widgets"
id="phonegap-plugin-push" version="2.3.0">
<name>PushPlugin</name>
<description> This plugin allows your application to receive push notifications on Android, iOS and Windows devices. Android uses Firebase Cloud Messaging. iOS uses Apple APNS Notifications. Windows uses Microsoft WNS Notifications. </description>
Expand All @@ -11,8 +11,8 @@
<clobbers target="PushNotification"/>
</js-module>
<engines>
<engine name="cordova" version=">=7.1.0"/>
<engine name="cordova-android" version=">=7.1.0"/>
<engine name="cordova" version=">=9.0.0"/>
<engine name="cordova-android" version=">=9.0.0"/>
<engine name="cordova-ios" version=">=4.5.0"/>
</engines>
<platform name="android">
Expand Down Expand Up @@ -42,12 +42,15 @@
</intent-filter>
</service>
</config-file>
<config-file target="config.xml" parent="/*">
<preference name="GradlePluginGoogleServicesEnabled" value="true" />
<preference name="GradlePluginGoogleServicesVersion" value="4.2.0" />
</config-file>
<preference name="ANDROID_SUPPORT_V13_VERSION" default="27.+"/>
<preference name="FCM_VERSION" default="17.0.+"/>
<framework src="com.android.support:support-v13:$ANDROID_SUPPORT_V13_VERSION"/>
<framework src="me.leolin:ShortcutBadger:1.1.17@aar"/>
<framework src="com.google.firebase:firebase-messaging:$FCM_VERSION"/>
<dependency id="cordova-support-google-services" version="~1.3.1"/>
<dependency id="phonegap-plugin-multidex" version="~1.0.0"/>
<source-file src="src/android/com/adobe/phonegap/push/FCMService.java" target-dir="src/com/adobe/phonegap/push/"/>
<source-file src="src/android/com/adobe/phonegap/push/PushConstants.java" target-dir="src/com/adobe/phonegap/push/"/>
Expand Down