pts/leveldb-1.1.0: Pull in third_party libs and use cmake to build #319
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leveldb doesn't build against gmock in the ubuntu repos. Pull in the third-party libs from the leveldb repo (release closest to the pinned commit). Also, this uses cmake --build, rather than make to build the target.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leveldb-1.1.0 doesn't build against gmock in the ubuntu repos (tested on Ubuntu 24.04.2 LTS). This change will pull in the third-party libs that are submodules in the leveldb repo's third_party folder and allows it to build successfully.
Also, this uses
cmake --build, rather than make to build the target.