chore: switch to @parseaple/typedstream#42
Merged
LingJueYa～ (LingJueYa) merged 4 commits intophoton-hq:mainfrom Mar 6, 2026
Merged
chore: switch to @parseaple/typedstream#42LingJueYa～ (LingJueYa) merged 4 commits intophoton-hq:mainfrom
LingJueYa～ (LingJueYa) merged 4 commits intophoton-hq:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR switches the project’s typedstream dependency from node-typedstream to the in-house fork @parseaple/typedstream, updating the runtime import and related tests to match the new package.
Changes:
- Replace
node-typedstreamwith@parseaple/typedstreamin the database attributedBody extraction code. - Update attributedBody extraction tests to import and construct
NSAttributedStringfrom@parseaple/typedstream. - Update dependency/lockfile metadata (including removing
package-lock.jsonand updatingbun.lock).
Reviewed changes
Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/core/database.ts | Updates typedstream import and references in attributedBody extraction. |
| tests/12-attributed-body.test.ts | Updates tests to use @parseaple/typedstream and new NSAttributedString constructor signature. |
| package.json | Swaps the dependency to @parseaple/typedstream. |
| package-lock.json | Removes the npm lockfile entirely. |
| bun.lock | Updates Bun lockfile to include @parseaple/typedstream (and other dependency resolution changes). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@parseaple/typedstreamis our in-house fork ofnode-typedstream. This makes our only dependency completely safe from supply chain attack. This package also introduces stricter types and edge cases handling.