Skip to content

Refactoring of perceptual metrics#291

Draft
jzakirov wants to merge 8 commits intomasterfrom
refactoring/perceptual
Draft

Refactoring of perceptual metrics#291
jzakirov wants to merge 8 commits intomasterfrom
refactoring/perceptual

Conversation

@jzakirov
Copy link
Collaborator

@jzakirov jzakirov commented Feb 6, 2022

Closes #261

Proposed Changes

  • Move LPIPS and DISTS into separate files
  • Mover test for LPIPS and DISTS into separate files
  • Do not inherit LPIPS and DISTS from StyleLoss class and re-implement all required (and simplified!) logic inside them
  • Add enable_grad flag to enable or disable gradients computation. Useful when using them as metrics, not loss functions.
  • Add tests to compare with reference implementations.
  • Validate why results of our LPIPS and original one differ
  • Validate failing test in DISTS

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semantic discrepancy between DISTS and ContentLoss parameters

2 participants

Comments