Skip to content

DAVE/E2EE support#30

Merged
phoxwupsh merged 3 commits intomainfrom
davey
Mar 12, 2026
Merged

DAVE/E2EE support#30
phoxwupsh merged 3 commits intomainfrom
davey

Conversation

@phoxwupsh
Copy link
Owner

DAVE/E2EE

Discord now enforce DAVE/E2EE for voice calls, as of now songbird upstream hasn't merged the PR for supporting it, we temporarily switch to beerpsi's fork now.

Bug fixes

  • Fix a that can cause panic if bot is restarted without gracefully shutdown while still in a voice channel
  • Fix a bug that if /leave is invoked while still playing, the bot could continue playing after the next join
  • Fix potential panic when someone can somehow invoke command with invalid parameter or outside of a guild

Discord now needs DAVE/E2EE for voice connection,
PR in origin songbird upstream hasn't been merged,
so swtich to beerpsi's fork to fix this

Refs:
serenity-rs/songbird#291
- remove most of the `unwrap`s that could cause panic and
  stop the bot when someone can somehow bypass certain restriction
  and invoke command with invalid parameter or outside of a guild
- add tests for yt-dlp version parsing and unknown fields parsing
  in help config
- fix a bug that can cause panic if bot is restarted without gracefully
  shutdown while still in a voice channel
- fix a bug that if /leave is invoked while still playing, the bot
  could continue playing after the next join
- adjust some docs so it can pass doctest
@phoxwupsh phoxwupsh merged commit f69a23c into main Mar 12, 2026
@phoxwupsh phoxwupsh deleted the davey branch March 12, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant