Skip to content

Conversation

@Grotax
Copy link

@Grotax Grotax commented Jun 20, 2025

No description provided.

@Grotax
Copy link
Author

Grotax commented Jun 20, 2025

@SMillerDev what do you think about php support:

  • PHP 8.4 and PHP 8.1 can't be supported with the same composer file

I see two options

  • drop support for php 8.1 in version 6.0 of feed-io which is the main branch
  • keep support for 8.1 in feed-io 6.0 create new release branch for 6.0 main branch supports 8.4 and drops 8.1 will be feed-io 7.0

@SMillerDev
Copy link

keep support for 8.1 in feed-io 6.0 create new release branch for 6.0 main branch supports 8.4 and drops 8.1 will be feed-io 7.0

I think this is the best option and most inline with previous versions. Unfortunately it's also a bit more work.

@SMillerDev
Copy link

Will you also register this new package on packagist or shall I?

@Grotax
Copy link
Author

Grotax commented Jun 20, 2025

I plan to do it but still working a bit on the repo before that

@Grotax Grotax force-pushed the update/docs branch 2 times, most recently from b3df65c to ce92d9b Compare June 20, 2025 08:37
@Grotax
Copy link
Author

Grotax commented Jun 20, 2025

I learned what the issue is, composer likes to include the php-http/discovery plugin which I'm sure makes sense.
But in this case it will lead composer to install some php adapter like symfony/http-client in some version that works with your current php version.

Disabling php-http/discovery fixes this by not installing some client and only using the mock stuff for the tests.

So while the code is maybe not up to date for 8.4 it does run.

- Changes links in multiple places
- Adds mkdocs instead of github pages, all content copied
- Adds dependabot to mange upgrades of php packages and actions
- Fresh setup for unit tests in github actions to see if the tests work or not
- Adding devcontainer to make it easier to work on this project with a certain php version
@Grotax Grotax merged commit 18f036f into main Jun 20, 2025
4 checks passed
@Grotax Grotax deleted the update/docs branch June 29, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants