If "Link" does not exist, then set it based on "guid" (PublicId.php) #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to automatically set a node's link from the <guid> element when the guid has isPermaLink="true" and no link is currently present. This addresses RSS feed parsing scenarios where the guid serves as a permalink but no explicit link element exists.
- Added conditional logic in
PublicId::setProperty()to check for permalink-enabled guid elements - Created a new CHANGELOG.md file to document this enhancement
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/FeedIo/Rule/PublicId.php | Added logic to set node link from guid when isPermaLink is true and link is null |
| CHANGELOG.md | Added new changelog file documenting the enhancement |
…r consistency with modern PHP practices and better readability. Co-authored-by: Copilot <[email protected]>
SMillerDev
approved these changes
Jul 24, 2025
Grotax
added a commit
that referenced
this pull request
Aug 13, 2025
- Add logic to set the node's link from the <guid> element when isPermaLink="true" and no link is present. (#12) - Do no longer default to 1800-01-01 as date for fetching feeds (#15) - Don't set if-modified-since header when discover feeds (#19) - Analysis of relative links for the Atom feed (#10) - Implicit null deprecations fixed (#17)
Grotax
added a commit
that referenced
this pull request
Aug 13, 2025
Changed - Add logic to set the node's link from the <guid> element when isPermaLink="true" and no link is present. (#12) - Do no longer default to 1800-01-01 as date for fetching feeds (#15) - Don't set if-modified-since header when discover feeds (#19) Fixed - Analysis of relative links for the Atom feed (#10) - Implicit null deprecations fixed (#17)
Merged
Grotax
added a commit
that referenced
this pull request
Aug 13, 2025
Changed - Add logic to set the node's link from the <guid> element when isPermaLink="true" and no link is present. (#12) - Do no longer default to 1800-01-01 as date for fetching feeds (#15) - Don't set if-modified-since header when discover feeds (#19) Fixed - Analysis of relative links for the Atom feed (#10) - Implicit null deprecations fixed (#17)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alexdebril#432
Cherry picked the changes from #8.