Skip to content

Conversation

@Grotax
Copy link

@Grotax Grotax commented Aug 13, 2025

  • Fixed in src/FeedIo/Reader/Result.php that the order of parameters is correct
  • Fixed missing methods from the NodeInterface

@Grotax Grotax changed the title Code quality 2 Code quality improvements Aug 13, 2025
@Grotax Grotax requested review from SMillerDev and Copilot August 13, 2025 19:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses code quality issues by fixing parameter order in the Result class constructor and adding missing methods to the NodeInterface. The changes resolve deprecated warnings about optional parameters preceding required parameters and eliminate method not found errors.

  • Fixed constructor parameter order in Result class by moving optional parameter to the end
  • Added missing methods to NodeInterface to resolve undefined method calls
  • Updated Rector configuration to enforce proper parameter ordering

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/FeedIo/Reader/Result.php Reordered constructor parameters to place optional $modifiedSince at the end
src/FeedIo/Reader.php Updated Result constructor call to match new parameter order
tests/FeedIo/Reader/ResultTest.php Updated test setup to use correct parameter order
tests/FeedIo/Reader/ResultMockFactory.php Updated mock factory to use correct parameter order
src/FeedIo/Feed/NodeInterface.php Added missing method declarations for host and link analysis functionality
src/FeedIo/Feed/Node.php Changed setHostInContent from protected to public and added return statement
rector.php Added rule to enforce optional parameters after required ones
phpstan-baseline.neon Removed resolved error entries from baseline

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Grotax Grotax merged commit b810297 into main Aug 16, 2025
5 checks passed
@Grotax Grotax deleted the code_quality_2 branch August 16, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant