Skip to content

[5.3] If "Link" does not exist, then set it based on "guid" #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025
Merged

[5.3] If "Link" does not exist, then set it based on "guid" #8

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5fbce91
[5.3] If "Link" does not exist, then set it based on "guid"
IgorA100 Dec 22, 2024
cb1e4f6
Add changelog entry
Grotax Jun 29, 2025
34dc254
Use strict equality sign
Grotax Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

### Changed

- Add logic to set the node's link from the <guid> element when isPermaLink="true" and no link is present. (#8)


### Fixed
Expand Down
5 changes: 5 additions & 0 deletions src/FeedIo/Rule/PublicId.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ class PublicId extends RuleAbstract
public function setProperty(NodeInterface $node, \DOMElement $element): void
{
$node->setPublicId($element->nodeValue);
if ($element->nodeName == 'guid'
&& $element->getAttribute('isPermaLink') === 'true'
&& is_null($node->getLink())) {
$node->setLink($element->nodeValue);
}
}

/**
Expand Down