Conversation
mehrdadkhoddami
commented
Oct 15, 2017
- Reformat generateButton to get label
- define Offset for range
- Refactor generateRange to have better algorithm and consider Offsets
- Refactor generateKeyboard to work with this new solution
- Add optional setMaxPageBasedOnLabels to generate max_page according to labels
- Reformat generateButton to get label - define Offset for range - Refactor generateRange to have better algorithm and consider Offsets - Refactor generateKeyboard to work with this new solution - Add optional setMaxPageBasedOnLabels to generate max_page according to labels
|
Hi, thanks for your contribution. Please make sure you adhere to the PSR-2 guidelines, in your case 4 spaces instead of tabs. Then I can take a look and see what your actual addition is 👍 |
|
Hi, Notes with thanks. |
|
I can have a look at the tests and see what's up. Before that though, could you please explain in more depth what this PR does exactly? Thanks! |
|
Sure.
Thank you. |