- 
                Notifications
    You must be signed in to change notification settings 
- Fork 826
PHP 8.4: Document RoundingMode #4080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
        
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            3 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      
    File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <reference xmlns="http://docbook.org/ns/docbook" xml:id="enum.roundingmode" role="enum"> | ||
| <title>The RoundingMode Enum</title> | ||
| <titleabbrev>RoundingMode</titleabbrev> | ||
|  | ||
| <partintro> | ||
| <section xml:id="enum.roundingmode.intro"> | ||
| &reftitle.intro; | ||
| <simpara> | ||
| The <enumname>RoundingMode</enumname> enum is used to specify how rounding | ||
| should be performed for <function>round</function>, | ||
| <function>bcround</function>, and <methodname>BCMath::round</methodname>. | ||
| </simpara> | ||
| </section> | ||
|  | ||
| <section xml:id="enum.roundingmode.synopsis"> | ||
| &reftitle.enumsynopsis; | ||
|  | ||
| <enumsynopsis> | ||
| <enumname>RoundingMode</enumname> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>HalfAwayFromZero</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the nearest integer. | ||
| If the decimal part is <literal>5</literal>, | ||
| round to the integer with the larger absolute value. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>HalfTowardsZero</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the nearest integer. | ||
| If the decimal part is <literal>5</literal>, | ||
| round to the integer with the smaller absolute value. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>HalfEven</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the nearest integer. | ||
| If the decimal part is <literal>5</literal>, | ||
| round to the even integer. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>HalfOdd</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the nearest integer. | ||
| If the decimal part is <literal>5</literal>, | ||
| round to the odd integer. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>TowardsZero</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the nearest integer with a smaller or equal absolute value. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>AwayFromZero</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the nearest integer with a greater or equal absolute value. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>NegativeInfinity</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the largest integer that is smaller or equal. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| <enumitem> | ||
| <enumidentifier>PositiveInfinity</enumidentifier> | ||
| <enumitemdescription> | ||
| Round to the smallest integer that is greater or equal. | ||
| </enumitemdescription> | ||
| </enumitem> | ||
|  | ||
| </enumsynopsis> | ||
| </section> | ||
| </partintro> | ||
| </reference> | ||
| <!-- Keep this comment at the end of the file | ||
| Local variables: | ||
| mode: sgml | ||
| sgml-omittag:t | ||
| sgml-shorttag:t | ||
| sgml-minimize-attributes:nil | ||
| sgml-always-quote-attributes:t | ||
| sgml-indent-step:1 | ||
| sgml-indent-data:t | ||
| indent-tabs-mode:nil | ||
| sgml-parent-document:nil | ||
| sgml-default-dtd-file:"~/.phpdoc/manual.ced" | ||
| sgml-exposed-tags:nil | ||
| sgml-local-catalogs:nil | ||
| sgml-local-ecat-files:nil | ||
| End: | ||
| vim600: syn=xml fen fdm=syntax fdl=2 si | ||
| vim: et tw=78 syn=sgml | ||
| vi: ts=1 sw=1 | ||
| --> | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you've taken all the description from the RFC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bit with the decimal part might need some adjustments either in the documentation for
round()or in here, becauseround()supports rounding to a specified precision instead of integers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have indeed taken them from the RFC, yeah the whole
round()semantics is... going to be a PITA.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will merge as is, feel free to open an issue about the wording to keep track of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4127.