Clarify type of a few INI values #4347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
approved these changes
Dec 27, 2024
Girgias
reviewed
Jan 14, 2025
Comment on lines
1513
to
1516
| If this option is enabled, and you are running PHP in a CGI environment (e.g. PHP-FPM) | ||
| you should not use standard RFC 2616 style HTTP status response headers, you should | ||
| instead use their RFC 3875 equivalent e.g. instead of header("HTTP/1.0 404 Not found"); | ||
| you should not use standard RFC 2616 style HTTP status response headers, you should | ||
| instead use their RFC 3875 equivalent e.g. instead of header("HTTP/1.0 404 Not found"); | ||
| you should use header("Status: 404 Not Found"); |
There was a problem hiding this comment.
Would be nice to get rid of the "you" usage here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by feedback on PR to clean up formatting of php.ini in php/php-src#17282