Skip to content

Conversation

@nielsdos
Copy link
Member

@nielsdos nielsdos commented May 8, 2025

Some PDO APIs changed.

cc @shivammathur

@mvorisek Would be great if CI is set up, I can only "build test" OCI.

Some PDO APIs changed.
@mvorisek
Copy link
Collaborator

mvorisek commented May 8, 2025

For CI setup look into https://github.com/mlocati/docker-php-extension-installer/blob/master/install-php-extensions. It is quite easy with Debian. Do not try with Alpine, with Alpine, it is quite complicated.

@mvorisek
Copy link
Collaborator

I now realized PHP 8.3 has working CI - https://github.com/php/php-src/blob/PHP-8.3/.github/actions/setup-oracle/action.yml - it was only unbundled, so the CI should be copied from there.

And in the future, if package is unbundled from php-src, never without CI :)

@nielsdos
Copy link
Member Author

I'm not going to set up CI here, but I see there's a separate WIP CI PR that stalled that could be used as a basis.

And in the future, if package is unbundled from php-src, never without CI :)

I agree

@shivammathur
Copy link
Member

@mvorisek @nielsdos
For CI, please see #16

@shivammathur shivammathur mentioned this pull request Jun 1, 2025
@mvorisek mvorisek merged commit baf125c into php:main Jun 1, 2025
@mvorisek
Copy link
Collaborator

mvorisek commented Jun 1, 2025

Thank you @shivammathur. With your CI I was able to verify this PR.

Thank you @nielsdos as well! ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants