Skip to content

Conversation

@mvorisek
Copy link
Collaborator

@mvorisek mvorisek commented Jun 17, 2025

repro: atk4/data@67bec67

described in: mlocati/docker-php-extension-installer#1113 (comment)

introduced in: #1 and in php/php-src@1b1ced5 and php/php-src@d6e320d

The HAVE_OCIENVNLSCREATE is used to call OCINlsCharSetNameToId and OCIEnvNlsCreate conditionally and the repro above shows when these functions are called, the repro exists with segfault.

Program received signal SIGSEGV, Segmentation fault.
0x00007fbeb6a0a197 in kpufch () from /usr/lib/oracle/21.1/client64/lib/libclntsh.so.21.1
#0  0x00007fbeb6a0a197 in kpufch () from /usr/lib/oracle/21.1/client64/lib/libclntsh.so.21.1
#1  0x00007fbeb15f5ea5 in oci_stmt_dtor (stmt=0x7fbeaf7411c0) at /tmp/pear/temp/pdo_oci/oci_statement.c:72
#2  0x000055676ce9ab28 in php_pdo_free_statement (stmt=0x7fbeaf7411c0) at /usr/src/php/ext/pdo/pdo_stmt.c:2139
#3  0x000055676ce9ac25 in pdo_dbstmt_free_storage (std=0x7fbeaf7412f8) at /usr/src/php/ext/pdo/pdo_stmt.c:2166
#4  0x000055676d2ae898 in zend_gc_collect_cycles () at /usr/src/php/Zend/zend_gc.c:1938
#5  0x000055676d1efc1a in zif_gc_collect_cycles (execute_data=0x7fbeb9c1ac40, return_value=0x7ffdae50cc20) at /usr/src/php/Zend/zend_builtin_functions.c:93
#6  0x000055676d2125b4 in ZEND_DO_FCALL_BY_NAME_SPEC_RETVAL_UNUSED_HANDLER () at /usr/src/php/Zend/zend_vm_execute.h:1567
#7  0x000055676d291e9a in execute_ex (ex=0x7fbeb9c17020) at /usr/src/php/Zend/zend_vm_execute.h:57287
#8  0x000055676d2967b8 in zend_execute (op_array=0x7fbeb9c61140, return_value=0x0) at /usr/src/php/Zend/zend_vm_execute.h:61655
#9  0x000055676d1cc2b5 in zend_execute_scripts (type=8, retval=0x0, file_count=3) at /usr/src/php/Zend/zend.c:1895
#10 0x000055676d1106f0 in php_execute_script (primary_file=0x7ffdae50e410) at /usr/src/php/main/main.c:2529
#11 0x000055676d35a45b in do_cli (argc=15, argv=0x7fbeba19ab20) at /usr/src/php/sapi/cli/php_cli.c:966
#12 0x000055676d35b2a5 in main (argc=15, argv=0x7fbeba19ab20) at /usr/src/php/sapi/cli/php_cli.c:1341

Maybe this is not related to Alpine or HAVE_OCIENVNLSCREATE (mlocati/docker-php-extension-installer#523 (comment) detection), but as reverting this fixes our CI, we revert this for now.

@mvorisek mvorisek changed the title Revert "always assume HAVE_OCIENVNLSCREATE" Revert "Always assume HAVE_OCIENVNLSCREATE" Jun 17, 2025
@mvorisek mvorisek merged commit e7a355e into main Jun 17, 2025
34 checks passed
@mvorisek mvorisek deleted the revert_HAVE_OCIENVNLSCREATE branch June 17, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant