Revert "Always assume HAVE_OCIENVNLSCREATE" #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repro: atk4/data@67bec67
described in: mlocati/docker-php-extension-installer#1113 (comment)
introduced in: #1 and in php/php-src@1b1ced5 and php/php-src@d6e320d
The
HAVE_OCIENVNLSCREATEis used to callOCINlsCharSetNameToIdandOCIEnvNlsCreateconditionally and the repro above shows when these functions are called, the repro exists with segfault.Maybe this is not related to Alpine or
HAVE_OCIENVNLSCREATE(mlocati/docker-php-extension-installer#523 (comment) detection), but as reverting this fixes our CI, we revert this for now.