-
Notifications
You must be signed in to change notification settings - Fork 12
Add Oracle AI Database 26ai BOOLEAN column fetch support #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sharadraju
wants to merge
2
commits into
main
Choose a base branch
from
boolean_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| --TEST-- | ||
| PDO_OCI: Insert BOOLEAN values into BOOLEAN column (Oracle 23ai+) | ||
| --EXTENSIONS-- | ||
| pdo | ||
| pdo_oci | ||
| --SKIPIF-- | ||
| <?php | ||
| require(getenv('PDO_TEST_DIR').'/pdo_test.inc'); | ||
| $db = PDOTest::factory(); | ||
|
|
||
| $version = $db->getAttribute(PDO::ATTR_SERVER_VERSION); | ||
| preg_match('/^(\d+)\./', $version, $matches); | ||
| $majorVersion = (int)$matches[1]; | ||
| if ($majorVersion < 23) { | ||
| die('skip BOOLEAN type supported from Oracle Database 23ai'); | ||
| } | ||
|
|
||
| PDOTest::skip(); | ||
| ?> | ||
| --FILE-- | ||
| <?php | ||
|
|
||
| require_once(getenv('PDO_TEST_DIR').'/pdo_test.inc'); | ||
| $db = PDOTest::factory(); | ||
|
|
||
| // Create table | ||
| $db->exec("CREATE TABLE IF NOT EXISTS test_bool (id NUMBER, bool_val BOOLEAN)"); | ||
|
|
||
| // Insert true | ||
| $stmt = $db->prepare("INSERT INTO test_bool (id, bool_val) VALUES (1, :val)"); | ||
| $val = true; | ||
| $stmt->bindParam(':val', $val, PDO::PARAM_BOOL); | ||
| $stmt->execute(); | ||
|
|
||
| // Insert false | ||
| $stmt = $db->prepare("INSERT INTO test_bool (id, bool_val) VALUES (2, :val)"); | ||
| $val = false; | ||
| $stmt->bindParam(':val', $val, PDO::PARAM_BOOL); | ||
| $stmt->execute(); | ||
|
|
||
| // Fetch and dump | ||
| $stmt = $db->query("SELECT id, bool_val FROM test_bool ORDER BY id"); | ||
| var_dump($stmt->fetchAll(PDO::FETCH_ASSOC)); | ||
| ?> | ||
| --CLEAN-- | ||
| <?php | ||
|
|
||
| require_once(getenv('PDO_TEST_DIR').'/pdo_test.inc'); | ||
| $db = PDOTest::factory(); | ||
|
|
||
| $db->exec("DROP TABLE test_bool PURGE"); | ||
|
|
||
| ?> | ||
| --EXPECT-- | ||
| array(2) { | ||
| [0]=> | ||
| array(2) { | ||
| ["id"]=> | ||
| string(1) "1" | ||
| ["bool_val"]=> | ||
| string(1) "1" | ||
| } | ||
| [1]=> | ||
| array(2) { | ||
| ["id"]=> | ||
| string(1) "2" | ||
| ["bool_val"]=> | ||
| string(1) "0" | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not return
false/truehere directly?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mvorisek for reviewing.
I wanted to keep this similar to #29 and make it consistent.
Any suggestions in the code as to how I can get this to return true/false?
If so, should we make changes for the fix we did for #29 to return true/false as well?