Fix windows builds and PIE composer.json tweaks #14
Conversation
| "php": ">=5.4" | ||
| }, | ||
| "php-ext": { | ||
| "extension-name": "timezonedb", |
There was a problem hiding this comment.
Extension name is not strictly required, since the package name is already correct, but it may help to be explicit.
| "configure-options": [] | ||
| "configure-options": [ | ||
| { | ||
| "name": "enable-timezonedb", |
There was a problem hiding this comment.
This --enable-timezonedb option is defined in config.m4 so it should be possible to provide this in the configure-options when using PIE
There was a problem hiding this comment.
But it is pointless. Using it is the default, doing --disable-timezonedb makes the extension not work.
| "configure-options": [] | ||
| "configure-options": [ | ||
| { | ||
| "name": "enable-timezonedb", |
There was a problem hiding this comment.
But it is pointless. Using it is the default, doing --disable-timezonedb makes the extension not work.
| - { os: windows-2019, php: "8.1" } | ||
| - { os: windows-2019, php: "8.0" } | ||
| - { os: windows-2022, php: "7.4" } | ||
| - { os: windows-2022, php: "7.3" } |
There was a problem hiding this comment.
Wouldn't it be better to just spell out all the right combinations instead of the wrong ones?
|
I've picked the relevant bits into #18 , thanks! |
2 participants
Originally in #12 this PR:
composer.json