Skip to content

Conversation

remicollet
Copy link
Member

See https://wiki.php.net/rfc/warnings-php-8-5#coercing_nan_to_other_types

                                                 
========DIFF========
001+ == FAIL! NAN ==
002+ expected:
003+ --- 
004+ Warning: unexpected NAN value was coerced to string in /work/GIT/pecl-and-ext/yaml/tests/bug_79866.php on line 24
005+ NAN
006+ ...
     
008+ got:--- NAN
009+ ...
========DONE========
FAIL Test PECL bug #79866 [tests/bug_79866.phpt] 

@bd808
Copy link
Collaborator

bd808 commented Oct 3, 2025

Thanks for the patch @remicollet. I will try to get to this on Sunday. I’ve been on holiday and ignoring computer things to the extent that is possible for a couple of weeks. :)

@remicollet
Copy link
Member Author

Thanks for the patch @remicollet. I will try to get to this on Sunday. I’ve been on holiday and ignoring computer things to the extent that is possible for a couple of weeks. :)

Nothing urgent, this is only a fix for a test ;)
Extension is still compatible with 8.5

@bd808 bd808 merged commit d61ffec into php:php7 Oct 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants