Skip to content

Conversation

@Jan-E
Copy link
Contributor

@Jan-E Jan-E commented Jul 6, 2019

@0mars
The Windows typedefs uint and ulong are no longer available in PHP 7.4
See https://github.com/php/php-src/blob/PHP-7.4/UPGRADING.INTERNALS#L213

This PR replaces uint by uint32_t and ulong by zend_ulong

See comparable PR for oauth and note the remarks about replacing ulong by zend_ulong
php/pecl-web_services-oauth#5

@coveralls
Copy link

coveralls commented Jul 6, 2019

Coverage Status

Coverage remained the same at 79.627% when pulling d35dd92 on Jan-E:fix_uint_ulong into 3dbdb7e on php:master.

@Jan-E
Copy link
Contributor Author

Jan-E commented Jul 7, 2019

I ran this locally against a omars/solr53 server on a Ubuntu virtualbox:

=====================================================================
Number of tests :  151               151
Tests skipped   :    0 (  0.0%) --------
Tests warned    :    0 (  0.0%) (  0.0%)
Tests failed    :    6 (  4.0%) (  4.0%)
Tests passed    :  145 ( 96.0%) ( 96.0%)
---------------------------------------------------------------------
Time taken      :   19 seconds
=====================================================================

=====================================================================
FAILED TEST SUMMARY
---------------------------------------------------------------------
SolrClient::getDebug() - Get request debug logs for the last request [tests\019.solrclient_getdebug.phpt]
SolrInputDocument::setVersion - Set document version [tests\059.solrinputdocument_setversion.phpt]
SolrQuery - Testing Date facet parameters [tests\062.solrquery_date_facet_parameters.phpt]
SolrQuery - testing StatsComponent [tests\064.solrquery_StatsComponent.phpt]
SolrUtils::getSolrVersion() - Returns solr dotted version [tests\082.solrutils_getsolrversion.phpt]
SolrResponse::getResponse() - maxScore [tests\104.solrresponse_get_response_maxscore.phpt]
=====================================================================

The solr dotted version test returned 2.5.0 (DEBUG)

The setVersion test had the same error as in the Appveyor build:
https://ci.appveyor.com/project/Jan-E/pecl-search-engine-solr/builds/25795124/job/6ju28mbs6df9t2h8#L1619

004+ int(1792016384)
004- int(1498562624496861184)

The getDebug test returned an extra line

013+ Mark bundle as not supporting multiuse

The other 3 failing tests had a variant of this:

001+ Notice: SolrQuery::removeStatsField(): Deleted last value from parameter. Removing parameter 'stats.field' from object instance. in tests\064.solrquery_StatsComponent.php on line 17
002+
003+ Notice: SolrQuery::removeStatsFacet(): Deleted last value from parameter. Removing parameter 'stats.facet' from object instance. in tests\064.solrquery_StatsComponent.php on line 24

Edit: 4 of the 6 failed tests are the result of the fact that a snapshot build (which I am doing) automatically enables PHP_SOLR_DEBUG/solr-debug. 'Mark bundle as not supporting multiuse' is apparently generated by curl. That might be related to my specific test setup. Which leaves only the 32/64 bit error in setVersion to be resolved.

@Jan-E
Copy link
Contributor Author

Jan-E commented Jul 7, 2019

BTW: compiled versions with the correct compiler (VS16) and OpenSSL 1.1.1 can be found here:
https://www.apachelounge.com/viewtopic.php?t=6617

Those are the ones I tested locally.

@Jan-E
Copy link
Contributor Author

Jan-E commented Jul 21, 2019

After merging this PR SolrInputDocument::setVersion remains as a TODO. Probably 32/64 bits:
https://ci.appveyor.com/project/Jan-E/pecl-search-engine-solr/builds/25795124/job/6ju28mbs6df9t2h8#L1619

@Jan-E Jan-E closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants