Skip to content

Add a composer.json to enable support for PIE #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add a composer.json to enable support for PIE #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b4af4
Add a composer.json to enable support for PIE
bix0r Dec 4, 2024
be01147
Update minimum php requirement to 8.1
bix0r Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"name": "php-solr/php-solr",
"type": "php-ext",
"license": "PHP-3.01",
"description": "Apache Solr extension",
"require": {
"php": ">= 8.1,<=8.4",
Copy link
Member

@remicollet remicollet Oct 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think composer.json and package.xml should be consistent.

So 7.4 to 8.4 for released version, but probably 7.4 to 8.5 for next patch version as build/test passes with 8.5.0RC2

Copy link
Collaborator Author

@bix0r bix0r Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I agree, it should be consistent. I will change this when I change the name.

Then we will remove support for older versions in a separate PR.

"ext-json": "*",
"ext-curl": "*",
"ext-libxml": "*"
},
"php-ext": {
"extension-name": "solr",
"configure-options": [
{
"name": "enable-solr",
"description": "Enable solr support"
},
{
"name": "enable-solr-debug",
"description": "Compile with solr in verbose mode"
},
{
"name": "enable-coverage",
"description": "Enable developer code coverage information"
}
]
}
}
Loading