Skip to content

Do not render the strong tag unnecessarily #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Do not render the strong tag unnecessarily #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions phpdotnet/phd/Package/Generic/XHTML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,27 +913,35 @@ public function format_classsynopsisinfo_ooclass_classname($open, $name, $attrs)
if ($open) {
if ($this->cchunk["classsynopsisinfo"]["ooclass"] === false) {
$this->cchunk["classsynopsisinfo"]["ooclass"] = true;
return '<span class="modifier">class</span> <strong class="'.$name.'">';
return '<span class="modifier">class</span> ';
}

return '<strong class="'.$name.'"> ';
return ' ';
}

return "</strong>";
if ($this->cchunk["classsynopsisinfo"]["ooclass"] === true) {
$this->cchunk["classsynopsisinfo"]["ooclass"] = null;
}

return "";
}

public function format_classsynopsisinfo_oointerface_interfacename($open, $name, $attrs)
{
if ($open) {
if ($this->cchunk["classsynopsisinfo"]["ooclass"] === false) {
$this->cchunk["classsynopsisinfo"]["ooclass"] = true;
return '<span class="modifier">interface</span> <strong class="classname">';
return '<span class="modifier">interface</span> ';
}

return ' <strong class="'.$name.'">';
return ' ';
}

return "</strong>";
if ($this->cchunk["classsynopsisinfo"]["ooclass"] === true) {
$this->cchunk["classsynopsisinfo"]["ooclass"] = null;
}

return "";
}

public function format_classsynopsisinfo($open, $name, $attrs)
Expand Down
2 changes: 1 addition & 1 deletion phpdotnet/phd/Package/PHP/XHTML.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ abstract class Package_PHP_XHTML extends Package_Generic_XHTML {
'classname' => array(
/* DEFAULT */ 'span',
'ooclass' => array(
/* DEFAULT */ 'strong',
/* DEFAULT */ 'format_suppressed_tags',
'classsynopsisinfo' => 'format_classsynopsisinfo_ooclass_classname',
),
),
Expand Down