Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions php.ini-development
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,6 @@
; Development Value: Off
; Production Value: Off

; variables_order
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS"

; zend.assertions
; Default Value: 1
; Development Value: 1
Expand Down Expand Up @@ -630,16 +625,14 @@ ignore_repeated_source = Off

; This directive determines which super global arrays are registered when PHP
; starts up. G,P,C,E & S are abbreviations for the following respective super
; globals: GET, POST, COOKIE, ENV and SERVER. There is a performance penalty
; paid for the registration of these arrays and because ENV is not as commonly
; used as the others, ENV is not recommended on productions servers. You
; can still get access to the environment variables through getenv() should you
; need to.
; globals: GET, POST, COOKIE, ENV and SERVER.
; In environments where _ENV is not registered, it is still possible to get
; access to the environment via getenv()
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS";
; Development Value: "EGPCS"
; Production Value: "EGPCS";
Comment on lines +632 to +633
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly these lines should be removed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other close by and related settings declare here their defaults, ini and production values, so it seems fine to follow that pattern.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They only do that when any of them differ from the built-in default.

; https://php.net/variables-order
variables_order = "GPCS"
;variables_order = "EGPCS"

; This directive determines which super global data (G,P & C) should be
; registered into the super global array REQUEST. If so, it also determines
Expand Down
19 changes: 6 additions & 13 deletions php.ini-production
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,6 @@
; Development Value: Off
; Production Value: Off

; variables_order
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS"

; zend.assertions
; Default Value: 1
; Development Value: 1
Expand Down Expand Up @@ -632,16 +627,14 @@ ignore_repeated_source = Off

; This directive determines which super global arrays are registered when PHP
; starts up. G,P,C,E & S are abbreviations for the following respective super
; globals: GET, POST, COOKIE, ENV and SERVER. There is a performance penalty
; paid for the registration of these arrays and because ENV is not as commonly
; used as the others, ENV is not recommended on productions servers. You
; can still get access to the environment variables through getenv() should you
; need to.
; globals: GET, POST, COOKIE, ENV and SERVER.
; In environments where _ENV is not registered, it is still possible to get
; access to the environment via getenv()
; Default Value: "EGPCS"
; Development Value: "GPCS"
; Production Value: "GPCS";
; Development Value: "EGPCS"
; Production Value: "EGPCS"
; https://php.net/variables-order
variables_order = "GPCS"
;variables_order = "EGPCS"

; This directive determines which super global data (G,P & C) should be
; registered into the super global array REQUEST. If so, it also determines
Expand Down