Remove ext/random backwards-compatibility headers #13108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ext/random was initially added in PHP 8.2, these headers started “forwarding” to the new ext/random/php_random.h to reduce the impact on existing extensions. As master already contains some breaking changes of the internal API of ext/random and as the last PHP version without ext/random will be EOL once master is released, it appears appropriate to drop these headers now.
bukka
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ext/random was initially added in PHP 8.2, these headers started “forwarding” to the new ext/random/php_random.h to reduce the impact on existing extensions.
As master already contains some breaking changes of the internal API of ext/random and as the last PHP version without ext/random will be EOL once master is released, it appears appropriate to drop these headers now.
see also: #8094 (comment)