Skip online tests by default, replace server image with base64 data #14070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged this for master only, because distributions will now need to pass the |
|
Thanks @iluuu1994 The master branch is ok because there are also some existing patches out there for the sapi/fpm/status.html.in page and there patch would need to be updated for PHP-8.3, or 8.2. So less issues for the package maintainers. But for the next PHP versions, those patches need to be updated anyway. |
Yes, that would be a good idea, see #16063. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GH-14058
Apparently all of our CI already passes the
--offlineflag, I wonder if it should be enabled for at least one of them.