Skip to content

Conversation

petk
Copy link
Member

@petk petk commented Aug 8, 2024

A very rare nicely named PHP_-prefixed preprocessor macros 😜 but still a bit confusing what these are exactly. Because things start to complicate when the target system is different than the build system. Let's go with this for now.

Hopefully I'll get the #12050 ready also for PHP-8.4...

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petk petk merged commit a355c35 into php:master Aug 8, 2024
@petk petk deleted the patch-AC_DEFINE-build-infos branch August 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants