Autotools: Patch apache2handler version check #15476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe ask RMs about removing the M4 macro? |
petk
changed the title
petk
force-pushed
the
patch-apache2handler-version-check
branch
from
7183309 to
84c3337
Compare
|
I've rebased this branch and added only the Autoconf macro obsoletion. Version is checked in the config.m4 file directly. |
|
I'll recheck if this works properly and merge it soon. |
The apxs -q HTTPD_VERSION variable is available since Apache 2.4.17. This change obsoletes the PHP_AP_EXTRACT_VERSION macro and checks the version in the config.m4 file directly. Version is checked against the dotted format instead of the version number.
petk
force-pushed
the
patch-apache2handler-version-check
branch
from
84c3337 to
912fecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Apache 2.4.17 there is HTTPD_VERSION variable available with the
apxs -qApache extension tool itself. Here are appended two commits:1st commit makes the PHP_AP_EXTRACT_VERSION macro obsolete
and the
2nd commit removes the PHP_AP_EXTRACT_VERSION macro.
I've quickly checked the open source extensions out there and none seem to use this macro. However, the removal can also wait for PHP 9.
I'm not sure if removing these M4 macros at this point can be done for PHP-8.4.