Refactor plain wrapper to handle mkdir itself

[Girgias]

This effectively inlines the behaviour of php_mkdir_ex() which is a deprecated API from at least 17 years ago, and also fixes some of the return values

[bukka]

This looks actually worse than it was. I think it might be just better to undeprecate it and leave it as it is.

[bukka]

The thing is that php_stream_mkdir is not an exactly the same replacement and some extensions might use this. And the plain wrapper code was a bit more readable with php_mkdir...

[Girgias]

The thing is that php_stream_mkdir is not an exactly the same replacement and some extensions might use this. And the plain wrapper code was a bit more readable with php_mkdir...

Nobody is using it: https://sourcegraph.com/search?q=context:global+php_mkdir+php_mkdir_ex+-f:file.h+-f:file.c+-f:plain_wrapper.c&patternType=keyword&sm=0

And arguably if you want to access the native functionality the correct thing to use VCWD_MKDIR()

[Girgias]

One thing also is to try to remove some of the very strange interdependencies between main/Zend/PHP extension.

I don't think it is ideal for main (or Zend) to depend on PHP extensions.

If the only problem is readability, then I can extract it again as a static function in the same file.

[cmb69]

I don't think it is ideal for main (or Zend) to depend on PHP extensions.

This is a valid point, in my opinion. For that reason alone, I consider this a sensible change (although I wouldn't call a removal a refactoring).

[bukka]

Ok I missed that it's in ext/standard . Fine with it...