Fork ext/zip to php-src #15575
Closed
Fork ext/zip to php-src #15575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ext/zip is actually bundled extension from https://github.com/pierrejoye/php_zip due to simpler managing on various distributions, libzip versions and PHP versions. This simplifies the contributing experience a bit by sending patches only to php-src. [skip ci]
|
Sorry, I miss this proposal.
This is already what most people are doing (ignoring CONTRIBUTING.md) At least, |
|
Yes, I got this from a lack of interest in making it a single place for this extension. 😄 Sure, if that works for you maintaining it, etc, no problem. I just found it a bit unconventional according to other extensions being developped only in php-src. For new features, I guess it sounds easier to develop them in a separate repo. But, I have no idea how this is then synced with PHP RFC process. So, no problem, if current repo works better then... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ext/zip is actually bundled extension from https://github.com/pierrejoye/php_zip due to simpler managing on various distributions, libzip versions and PHP versions. This simplifies the contributing experience a bit by sending patches only to php-src.
Can we simplify this part for PHP-8.4 already or should we wait a bit longer?