Skip to content

Generated arginfo header files: use known strings for prop names when… #15751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 30, 2024
Merged

Generated arginfo header files: use known strings for prop names when… #15751

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11ce460
Generated arginfo header files: use known strings for prop names when…
DanielEScherzer Sep 4, 2024
0a146f0
zend_string.h: add a note about updating known strings
DanielEScherzer Sep 5, 2024
78393d6
Update for `ZEND_STR_DEPRECATED_CAPITALIZED` renaming
DanielEScherzer Sep 10, 2024
8a119da
gen_stub: improve a bit
DanielEScherzer Sep 28, 2024
d3ce1b6
Fix end() on constant
DanielEScherzer Sep 28, 2024
7bc8df4
More whitespaces fixes
DanielEScherzer Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions build/gen_stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3097,7 +3097,7 @@ public function getDeclaration(array $allConstInfos): string {
$code .= $defaultValue->initializeZval($zvalName);
}

[ $stringInit, $nameCode, $stringRelease ] = $this->getString( $propertyName );
[$stringInit, $nameCode, $stringRelease] = $this->getString( $propertyName );
$code .= $stringInit;

if ($this->exposedDocComment) {
Expand Down Expand Up @@ -3151,7 +3151,8 @@ private function getString( string $propName ): array {
$nameCode,
"\tzend_string_release($nameCode);\n"
];
$minPhp = $phpVersionIdMinimumCompatibility ?? PHP_84_VERSION_ID;
// If not set, use the current latest version
$minPhp = $phpVersionIdMinimumCompatibility ?? end( ALL_PHP_VERSION_IDS );
if ( $minPhp < PHP_80_VERSION_ID ) {
// No known strings in 7.0
return $result;
Expand Down
Loading