Skip to content

ext/phar: Refactor flushing of archive to only take string stub file #15864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2024
Merged

ext/phar: Refactor flushing of archive to only take string stub file #15864

merged 6 commits into from
Sep 14, 2024

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Sep 12, 2024

No description provided.

@Girgias Girgias requested a review from nielsdos September 12, 2024 21:04
@Girgias Girgias requested a review from bukka as a code owner September 13, 2024 11:45
nielsdos
nielsdos approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong here, it's a nice cleanup.
Maybe just wait for Jakub to give the green light for the slight API change in ext/standard, but that also looks harmless to me.

@Girgias Girgias merged commit 2513258 into php:master Sep 14, 2024
10 checks passed
@Girgias Girgias deleted the phar-flush branch September 14, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

Assignees

No one assigned

Labels

Extension: phar Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Girgias @nielsdos