Skip to content

ext/standard/browscap.c: Minor refactorings #15885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2024
Merged

ext/standard/browscap.c: Minor refactorings #15885

merged 1 commit into from
Sep 17, 2024
+14 −15

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Sep 14, 2024

  • Use more appropriate types
  • Add const modifiers
  • Reduce scope of some variable
  • Prevent shadowing of variable

@Girgias
ext/standard/browscap.c: Minor refactorings
2b8ec3c 
- Use more appropriate types
- Add const modifiers
- Reduce scope of some variable
- Prevent shadowing of variable
@Girgias Girgias requested a review from bukka as a code owner September 14, 2024 14:05
@Girgias Girgias merged commit ae4ef32 into php:master Sep 17, 2024
10 checks passed
@Girgias Girgias deleted the browscap-refacto branch September 17, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka bukka approved these changes

Assignees

No one assigned

Labels

Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Girgias @bukka