Run snmp tests in Windows CI, again #15896
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was broken when CI was moved to GH, since `APPVEYOR_BUILD_FOLDER` is no longer set; instead we use `GITHUB_WORKSPACE` which has the same meaning.
|
E.g. https://github.com/php/php-src/actions/runs/10872068852/job/30166659461 shows that a couple of snmp tests are skipped (slow tests hitting a timeout), while the two expected xfailing tests are not reported. |
|
Oh, this shouldn't target master, but rather PHP-8.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was broken when CI was moved to GH, since
APPVEYOR_BUILD_FOLDERis no longer set; instead we useGITHUB_WORKSPACEwhich has the same meaning.