Skip to content

Fix some misleading comments about __clone() never being executed #15926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Fix some misleading comments about __clone() never being executed #15926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Zend/zend_exceptions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ static zend_object *zend_default_exception_new(zend_class_entry *class_type) /*
/* {{{ Clone the exception object */
ZEND_COLD ZEND_METHOD(Exception, __clone)
{
/* Should never be executable */
/* __clone() is private but this is reachable with reflection */
zend_throw_exception(NULL, "Cannot clone object using __clone()", 0);
}
/* }}} */
Expand Down
4 changes: 2 additions & 2 deletions ext/reflection/php_reflection.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1573,7 +1573,7 @@ static int get_parameter_default(zval *result, parameter_reference *param) {
/* {{{ Preventing __clone from being called */
ZEND_METHOD(ReflectionClass, __clone)
{
/* Should never be executable */
/* __clone() is private but this is reachable with reflection */
_DO_THROW("Cannot clone object using __clone()");
}
/* }}} */
Expand Down Expand Up @@ -7178,7 +7178,7 @@ ZEND_METHOD(ReflectionAttribute, __construct)

ZEND_METHOD(ReflectionAttribute, __clone)
{
/* Should never be executable */
/* __clone() is private but this is reachable with reflection */
_DO_THROW("Cannot clone object using __clone()");
}

Expand Down