Skip to content

Fix GH-15982: Assertion failure with array_find when references are involved #15983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-15982: Assertion failure with array_find when references are involved #15983

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

No description provided.

@nielsdos nielsdos requested a review from bukka as a code owner September 22, 2024 10:02
@nielsdos nielsdos linked an issue Sep 22, 2024 that may be closed by this pull request
Assertion failure with array_find when references are involved #15982
Closed
Girgias
Girgias approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me considering other array functions behave that way.

bukka
bukka approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@bukka bukka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@nielsdos nielsdos closed this in 27b3131 Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bukka bukka bukka approved these changes

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: standard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failure with array_find when references are involved

3 participants

@nielsdos @bukka @Girgias