Fix GH-15986: Double-free due to Pdo\Pgsql::setNoticeCallback() #15987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to release the fcall info cache instead of destroying it.
|
Do you have a test case showcasing this? As it feels like dtor is correct due to the |
See #15986. I've noticed that when running https://github.com/php/php-src/blob/master/ext/pdo_pgsql/tests/pdopgsql_setNoticeCallback_trampoline_no_leak.phpt under ASan (therefore I didn't add a new test case). |
|
The problem with the dtor in this case is, that it decreases the refcount of the ( |
Ah, right, okay I see the problem. I was worried this meant all cases where the ZPP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to release the fcall info cache instead of destroying it.