Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

php / php-src Public

Notifications You must be signed in to change notification settings
Fork 8k
Star 39.5k

Code
Issues 863
Pull requests 694
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

Refactor implementation of ldap_modify_batch()#16033

Merged

Girgias merged 14 commits intophp:masterphp/php-src:masterfrom

Girgias:ldap-modify_batch-refactoringGirgias/php-src:ldap-modify_batch-refactoringCopy head branch name to clipboard

Sep 27, 2024

Conversation Commits14 (14)Checks Files changed

Merged

Refactor implementation of ldap_modify_batch()#16033
Girgias merged 14 commits intophp:masterfrom
Girgias:ldap-modify_batch-refactoring

Commits

Commits on Sep 27, 2024

ext/ldap: Add test cases for (Value|Type)Errors in ldap_modify_batch()
Girgias
committed
ext/ldap: Add test for reference in modification array
Girgias
committed
[skip ci] ext/ldap: Clean-up comment
Girgias
committed
ext/ldap: Use zend_*_has_nul_byte() APIs
Girgias
committed
ext/ldap: Use zend_array_is_list() API to check "values" array
Girgias
committed
ext/ldap: Join declaration and assignments
Girgias
committed
ext/ldap: Fetch the values directly via hash API
Girgias
committed
ext/ldap: Refactor verification of modification entry
Girgias
committed
ext/ldap: Use EMPTY_SWITCH_DEFAULT_CASE();
Girgias
committed
ext/ldap: Refactor execution of batch command
Girgias
committed
ext/ldap: Refactor looping of modifications array
Girgias
committed
ext/ldap: Refactor traversal of modification values
Girgias
committed
ext/ldap: Remove unnecessary scoping
Girgias
committed
ext/ldap: Move server controls check prior to allocating modifications
Girgias
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.