Re-introduce caching for Windows CI #16044
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had been done when running on AppVeyor, but had been dropped when Windows CI was migrated to Github. While not terribly useful regarding the performance (maybe a minute can be saved), it still appears to be reasonable to avoid unnecessary requests to downloads.php.net.
To have the branch available in the action, we make detection of the target branch a separate step.
Note that this adds 140MB to the cache for each PHP version (currently only master), and each architecture (currently only x64). I don't think this is
bea problem.