random: Do not use ZVAL_DUP in Randomizer::shuffleArray()
#16072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Internals Book says: > The ZVAL_DUP macro is similar to ZVAL_COPY, but will duplicate arrays, rather > than just incrementing their refcount. If you are using this macro, you are > almost certainly doing something very wrong. Replace this by an explicit call to `zend_array_dup()`, as done in `php_array_diff()`. Besides being more explicit in what is happening, this likely also results in better assembly.
arnaud-lb
reviewed
Sep 26, 2024
| ZEND_PARSE_PARAMETERS_END(); | ||
|
|
||
| ZVAL_DUP(return_value, array); | ||
| RETVAL_ARR(zend_array_dup(Z_ARRVAL_P(array))); |
There was a problem hiding this comment.
Is there a particular reason for not using SEPARATE_ARRAY()? This would avoid a duplication when it's not stricly necessary, e.g.:
$r->shuffleArray(range(0,10));
There was a problem hiding this comment.
Do you have a specific suggestion as how to adjust the code to leverage SEPARATE_ARRAY? My attempts all lead to either memory unsafety or SEPARATE_ARRAY not providing a value-add.
There was a problem hiding this comment.
You are right indeed, there SEPARATE_ARRAY would not make sense here.
nielsdos
approved these changes
Sep 27, 2024
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
) PHP Internals Book says: > The ZVAL_DUP macro is similar to ZVAL_COPY, but will duplicate arrays, rather > than just incrementing their refcount. If you are using this macro, you are > almost certainly doing something very wrong. Replace this by an explicit call to `zend_array_dup()`, as done in `php_array_diff()`. Besides being more explicit in what is happening, this likely also results in better assembly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP Internals Book says:
Replace this by an explicit call to
zend_array_dup(), as done inphp_array_diff(). Besides being more explicit in what is happening, this likely also results in better assembly.