Fix FFI prototypes (these functions can't return NULL) #16075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-lb
reviewed
Sep 26, 2024
ext/ffi/ffi.stub.php
Outdated
| public static function cdef(string $code = "", ?string $lib = null): FFI {} | ||
|
|
||
| public static function load(string $filename): ?FFI {} | ||
| public static function load(string $filename): FFI {} |
There was a problem hiding this comment.
I think it can return NULL during preloading?
There was a problem hiding this comment.
You are right. Thanks for catching this.
Everything else is OK?
dstogov
added a commit
that referenced
this pull request
Sep 26, 2024
* PHP-8.4: Fix FFI prototypes (these functions can't return NULL) (#16075)
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.