Skip to content

Fix property_exists() for XMLReader #16079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 28, 2024
Merged

Fix property_exists() for XMLReader #16079

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28551ce
Fix property_exists() for XMLReader
kocsismate Sep 26, 2024
5f76e86
Fix has_property handler + add unset handler
kocsismate Sep 27, 2024
ffb41ea
Fix possible memory leak
kocsismate Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ext/xmlreader/php_xmlreader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,25 @@ zval *xmlreader_get_property_ptr_ptr(zend_object *object, zend_string *name, int
}
/* }}} */

static int xmlreader_has_property(zend_object *object, zend_string *name, int type, void **cache_slot)
{
xmlreader_object *obj = php_xmlreader_fetch_object(object);
xmlreader_prop_handler *hnd = zend_hash_find_ptr(&xmlreader_prop_handlers, name);

if (hnd != NULL) {
zval rv;
if (xmlreader_property_reader(obj, hnd, &rv) == FAILURE) {
return 0;
} else {
zval_ptr_dtor(&rv);
return 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should respect the rules for isset and empty, so for empty this should call zend_is_true for example.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, I wanted to copy-paste the code I wrote for DatePeriod, but somehow I got distracted... I'm fixing it right now.

}
}

return zend_std_has_property(object, name, type, cache_slot);
}


/* {{{ xmlreader_read_property */
zval *xmlreader_read_property(zend_object *object, zend_string *name, int type, void **cache_slot, zval *rv)
{
Expand Down Expand Up @@ -1293,6 +1312,7 @@ PHP_MINIT_FUNCTION(xmlreader)
memcpy(&xmlreader_object_handlers, &std_object_handlers, sizeof(zend_object_handlers));
xmlreader_object_handlers.offset = XtOffsetOf(xmlreader_object, std);
xmlreader_object_handlers.free_obj = xmlreader_objects_free_storage;
xmlreader_object_handlers.has_property = xmlreader_has_property;
xmlreader_object_handlers.read_property = xmlreader_read_property;
xmlreader_object_handlers.write_property = xmlreader_write_property;
xmlreader_object_handlers.get_property_ptr_ptr = xmlreader_get_property_ptr_ptr;
Expand Down
46 changes: 46 additions & 0 deletions ext/xmlreader/tests/virtual_properties2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
--TEST--
Virtual property existence tests
--EXTENSIONS--
xmlreader
--FILE--
<?php

$di = new XMLReader();

var_dump(isset($di->attributeCount));
var_dump(empty($di->attributeCount));
var_dump(property_exists($di, "attributeCount"));

var_dump(isset($di->baseURI));
var_dump(empty($di->baseURI));
var_dump(property_exists($di, "baseURI"));

var_dump(isset($di->depth));
var_dump(empty($di->depth));
var_dump(property_exists($di, "depth"));

var_dump(isset($di->hasAttributes));
var_dump(empty($di->hasAttributes));
var_dump(property_exists($di, "hasAttributes"));

var_dump(isset($di->hasValue));
var_dump(empty($di->hasValue));
var_dump(property_exists($di, "hasValue"));

?>
--EXPECTF--
bool(true)
bool(false)
bool(true)
bool(true)
bool(false)
bool(true)
bool(true)
bool(false)
bool(true)
bool(true)
bool(false)
bool(true)
bool(true)
bool(false)
bool(true)
Loading