Skip to content

Conversation

jorgsowa
Copy link
Contributor

Removes unused headers from link.c. Initially, I wanted to remove just ctype.h, but found others that are also unused.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Apparently, this has been overlooked for a long time; win32/pwd.h is removed as of PHP 5.2.0.

@jorgsowa jorgsowa force-pushed the remove-unused-headers-link branch from f0ca8aa to 11cdcc3 Compare October 13, 2024 17:38
@jorgsowa
Copy link
Contributor Author

I will take care of other places also.

@jorgsowa jorgsowa force-pushed the remove-unused-headers-link branch from 11cdcc3 to 618c81f Compare January 15, 2025 23:34
@jorgsowa
Copy link
Contributor Author

Is it fine to merge this PR or should I close the PR?

@bukka bukka merged commit 8c11382 into php:master Jan 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants