Remove dead code in fpm of redirect_status #16090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a feature copied from the CGI SAPI, but since cgi is always 0 in fpm, this code is dead. Similarly, the INI settings related to this are no longer used after removing this dead code.
bukka
approved these changes
Sep 28, 2024
jorgsowa
pushed a commit
to jorgsowa/php-src
that referenced
this pull request
Oct 1, 2024
This is a feature copied from the CGI SAPI, but since cgi is always 0 in fpm, this code is dead. Similarly, the INI settings related to this are no longer used after removing this dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a feature copied from the CGI SAPI, but since CGI is always 0 in FPM, this code is dead. Similarly, the INI settings related to this are no longer used after removing this dead code.
I identified this a while back when working on the security fix for CGI.