ext/standard/head.c: Small refactoring of headers_sent()
#16109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
head-argnum
branch
from
6096c8b to
d344a08
Compare
devnexen
reviewed
Sep 29, 2024
| ZEND_TRY_ASSIGN_REF_LONG(by_ref_line, line); | ||
| } | ||
|
|
||
| RETURN_BOOL(SG(headers_sent)); |
There was a problem hiding this comment.
quick question: is there a reason why headers_sent global is not just a bool ?
There was a problem hiding this comment.
Because it hasn't been refactored since the move to C99, but it should yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.