Skip to content

[skip ci] Support running of a selected nightly job #16144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[skip ci] Support running of a selected nightly job #16144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 30 additions & 12 deletions .github/workflows/nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,25 @@ name: Nightly
on:
schedule:
- cron: "0 1 * * *"
workflow_dispatch: ~
workflow_dispatch:
inputs:
job:
required: false
default: '*'
type: choice
options:
- '*'
- ALPINE
- LINUX_X64
- LINUX_X32
- MACOS
- COVERAGE_DEBUG_NTS
- COMMUNITY
- OPCACHE_VARIATION
- MSAN
- LIBMYSQLCLIENT
- PECL
- WINDOWS
permissions:
contents: read
jobs:
Expand Down Expand Up @@ -42,7 +60,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
ALPINE:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'ALPINE')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -101,7 +119,7 @@ jobs:

LINUX_X64:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'LINUX_X64')
services:
mysql:
image: mysql:8.3
Expand Down Expand Up @@ -212,7 +230,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
LINUX_X32:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'LINUX_X32')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -291,7 +309,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
MACOS:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'MACOS')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -349,7 +367,7 @@ jobs:
with:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
COVERAGE_DEBUG_NTS:
if: github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch'
if: (github.repository == 'php/php-src') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS')
Copy link
Member

@iluuu1994 iluuu1994 Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. It wouldn't execute on workflow_dispatch in forks anymore.

Suggested change
if: (github.repository == 'php/php-src') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS')
if: github.repository == 'php/php-src' || (github.event_name == 'workflow_dispatch' && (inputs.job == '*' || inputs.job == 'COVERAGE_DEBUG_NTS'))

services:
mysql:
image: mysql:8.3
Expand Down Expand Up @@ -414,7 +432,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
COMMUNITY:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'COMMUNITY')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -602,7 +620,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
OPCACHE_VARIATION:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'OPCACHE_VARIATION')
services:
mysql:
image: mysql:8.3
Expand Down Expand Up @@ -699,7 +717,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
MSAN:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'MSAN')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -797,7 +815,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
LIBMYSQLCLIENT:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'LIBMYSQLCLIENT')
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -847,7 +865,7 @@ jobs:
with:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
PECL:
if: github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch'
if: (github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'PECL')
Copy link
Member

@iluuu1994 iluuu1994 Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be simplified to:

Suggested change
if: (github.repository == 'php/php-src' || github.event_name == 'workflow_dispatch') && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'PECL')
if: github.repository == 'php/php-src' || (github.event_name == 'workflow_dispatch' && (inputs.job == '*' || inputs.job == 'PECL'))

runs-on: ubuntu-22.04
env:
CC: ccache gcc
Expand Down Expand Up @@ -961,7 +979,7 @@ jobs:
token: ${{ secrets.ACTION_MONITORING_SLACK }}
WINDOWS:
needs: GENERATE_MATRIX
if: ${{ needs.GENERATE_MATRIX.outputs.branches != '[]' }}
if: needs.GENERATE_MATRIX.outputs.branches != '[]' && (github.event_name != 'workflow_dispatch' || inputs.job == '*' || inputs.job == 'WINDOWS')
strategy:
fail-fast: false
matrix:
Expand Down