Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

php / php-src Public

Notifications You must be signed in to change notification settings
Fork 8k
Star 39.6k

Code
Issues 866
Pull requests 693
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

ext/ldap: Refactor `php_ldap_do_modify()`#16146

Merged

Girgias merged 13 commits intophp:masterphp/php-src:masterfrom

Girgias:ldap-do-modify-refactoGirgias/php-src:ldap-do-modify-refactoCopy head branch name to clipboard

Oct 1, 2024

Conversation Commits13 (13)Checks Files changed

Merged

ext/ldap: Refactor `php_ldap_do_modify()`#16146
Girgias merged 13 commits intophp:masterfrom
Girgias:ldap-do-modify-refacto

Commits

Commits on Oct 1, 2024

ext/ldap: Add tests for php_ldap_do_modify()
Girgias
committed
ext/ldap: php_ldap_do_modify() throw ValueError when entries array is empty
Girgias
committed
ext/ldap: Handle attribute => value case directly
Girgias
committed
ext/ldap: Ensure list of attribute values is not empty
Girgias
committed
ext/ldap: Check that attribute values is a list before traversal
Girgias
committed
ext/ldap: Reduce scope of variables
Girgias
committed
ext/ldap: Use HASH_FOREACH macro
Girgias
committed
ext/ldap: Zero out arrays and traverse them as NULL terminated list
Girgias
committed
ext/ldap: Refactor loop to a HASH_FOREACH loop
Girgias
committed
ext/ldap: Promote warning to ValueError if array is not a dict
Girgias
committed
ext/ldap: Check array key does not have any nul bytes
Girgias
committed
ext/ldap: Check that array key is not empty
Girgias
committed
ext/ldap: Rename variable and move closer to usage site
Girgias
committed

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.