Skip to content

x86 builds on Windows are warning level 1 clean #16170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2024
Merged

x86 builds on Windows are warning level 1 clean #16170

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25e6cde
x86 builds on Windows are warning level 1 clean
cmb69 Oct 2, 2024
eea3e22
Temporarily verify x86 build on Windows
cmb69 Oct 2, 2024
5384c48
[skip ci] Revert "Temporarily verify x86 build on Windows"
cmb69 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions .github/scripts/windows/build_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,7 @@ if %errorlevel% neq 0 exit /b 3
if "%THREAD_SAFE%" equ "0" set ADD_CONF=%ADD_CONF% --disable-zts
if "%INTRINSICS%" neq "" set ADD_CONF=%ADD_CONF% --enable-native-intrinsics=%INTRINSICS%

rem Some undefined behavior is reported on 32-bit, this should be fixed
if "%PLATFORM%" == "x86" (
set CFLAGS=/W1
) else (
set CFLAGS=/W1 /WX
)
set CFLAGS=/W1 /WX

cmd /c configure.bat ^
--enable-snapshot-build ^
Expand Down