[skip ci] ext/soap: Use HASH_FOREACH macro

[Girgias]

@nielsdos I don't understand why ext/soap/tests/gh12392.phpt fails with use after frees.

But this code is extremely confusing and I'm guessing bug prone as it has recursing behaviour with different functions just calling themselves with the same HashTable.

Not sure if you have any ideas or not.

[nielsdos]

@Girgias this patch is wrong. You may not use the foreach macros if during iteration the hashtable changes. The uafs come from the fact that the bucket pointer is stored in a local variable, and when the hashtable resizes that pointer may become stale.
In fact, I once fixed a bug in soap by changing a foreach macro into these "hash_move" functions.

[nielsdos]

Actually, it's part of this code that I changed from the macro to what it currently is!
So if you would've used "git blame" you could've seen why ;)

[Girgias]

Ah fair enough, didn't know this fact about HashTables.

But I guess my question is why do the HashTables need to be fixed in the first place?

[nielsdos]

The name of the function is just bad. It looks up for each attribute if there's a reference to another part of the current/another schema, and links them up.